lib: rename basic_decode as decode_without_cm
#30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psurply
reviewed
Apr 23, 2025
This patch is updating the current public API of the Crash Log library. Previously there was a function in the API for decoding called `decode` which was using the collateral manager and there was another function called `basic_decode` which was not using the collateral manager. For clarify the concepts, this patch is renaming the `basic_decode` for `decode_without_cm`, the intention is to be more precise on the usage of that function as the term "basic" is not very clear and the usage of that function is to call the decoding library in the scenario where there is no Collateral Manager available. Signed-off-by: Rivas Paz, Jose L <jose.l.rivas.paz@intel.com>
jlrivasp
force-pushed
the
dev/decode_without_cm
branch
from
a1d9329 to
cac590a
Compare
psurply
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is updating the current public API of the Crash Log library.
Previously there was a function in the API for decoding called
decodewhich was using the collateral manager and there was another function calledbasic_decodewhich was not using the collateral manager.For clarify the concepts, this patch is renaming the
basic_decodefordecode_without_cm, the intention is to be more precise on the usage of that function as the term "basic" is not very clear and the usage of that function is to call the decoding library in the scenario where there is no Collateral Manager available.